[UR] Consolidate platform and adapter backend enums into one. #17605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Mar 24, 2025
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Mar 25, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM! It looks like a NFC to me, is that right?
Contributor
Author
|
yeah I guess it kind of is, although as we've seen it does break other changes that use the affected enums |
kbenzie
approved these changes
Apr 1, 2025
Seanst98
approved these changes
Apr 2, 2025
Contributor
Author
|
ping @intel/dpcpp-nativecpu-reviewers note this is not a new patch, it's an attempt to re-land with a minor fix |
martygrant
approved these changes
Apr 4, 2025
kbenzie
approved these changes
Apr 4, 2025
hvdijk
approved these changes
Apr 7, 2025
Contributor
hvdijk
left a comment
hvdijk
left a comment
There was a problem hiding this comment.
The NativeCPU changes are identical to the earlier attempt so still look fine, thanks.
Contributor
Author
|
arc fails due to #18416 @intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second attempt to land #16173